Format code with prettier and gofumpt #1886
Conversation
![deepsource-autofix[bot]](https://avatars.githubusercontent.com/in/57168?s=60&v=4){kind=small}
This commit fixes the style issues introduced in 4e10e17 according to the output from prettier and gofumpt. Details: https://deepsource.io/gh/vdaas/vald/transform/3468f768-127e-425d-9457-42cc8d2ef2b2/
Deploying with
|
| Latest commit: |
dc660b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://850693d5.vald.pages.dev |
| Branch Preview URL: | https://deepsource-transform-885bce6.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com>
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
docs/tutorial/vald-agent-standalone-on-k8s.md|219 col 8| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Load
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|225 col 10| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|255 col 25| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|261 col 26| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|326 col 14| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: B
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|340 col 31| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|343 col 32| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/usecase/usage-example.md|85 col 150| Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://www.grammar-monster.com/lessons/commas_before_conjunctions.htm
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION
docs/user-guides/deployment.md|129 col 16| Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
docs/user-guides/filtering-configuration.md|23 col 4| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/user-guides/filtering-configuration.md|30 col 4| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/user-guides/filtering-configuration.md|45 col 4| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/user-guides/filtering-configuration.md|53 col 4| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| | object | bytes | | \* | the binary object | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :----- | :---- | :------: | :---------------- | | ||
| | id | string | | \* | the object ID | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | object | bytes | | \* | the binary object | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :----- | :---- | :------: | :---------------- | | ||
| | id | string | | \* | the object ID | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | object | bytes | | \* | the binary object | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :----- | :---- | :------: | :---------------- | | ||
| | id | string | | \* | the object ID | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | object | bytes | | \* | the binary object | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :----- | :---- | :------: | :---------------- | | ||
| | id | string | | \* | the object ID | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | object | bytes | | \* | the binary object | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :----- | :---- | :------: | :---------------- | | ||
| | id | string | | \* | the object ID | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| ``` | ||
| ```bash | ||
| NAME READY STATUS RESTARTS AGE | ||
| vald-agent-ngt-0 1/1 Running 0 20m |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 20 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
| ```bash | ||
| NAME READY STATUS RESTARTS AGE | ||
| vald-agent-ngt-0 1/1 Running 0 20m | ||
| vald-agent-ngt-1 1/1 Running 0 20m |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 20 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
| NAME READY STATUS RESTARTS AGE | ||
| vald-agent-ngt-0 1/1 Running 0 20m | ||
| vald-agent-ngt-1 1/1 Running 0 20m | ||
| vald-agent-ngt-2 1/1 Running 0 20m |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 20 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
| vald-agent-ngt-0 1/1 Running 0 20m | ||
| vald-agent-ngt-1 1/1 Running 0 20m | ||
| vald-agent-ngt-2 1/1 Running 0 20m | ||
| vald-agent-ngt-3 1/1 Running 0 20m |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 20 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
| @@ -147,89 +148,89 @@ This chapter uses [NGT](https://github.com/yahoojapan/ngt) as Vald Agent to perf | |||
| <details><summary>The detailed explanation of example code is here</summary><br> | |||
| This will execute 6 steps. | |||
|
|
|||
| 1. init | |||
| 1. init | |||
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Init
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
kpango
force-pushed
the
main
branch
2 times, most recently
from
9b3087a
to
4a659f2
Compare
|
|
||
| </details> | ||
|
|
||
| 1. load | ||
| 1. load |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Load
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| } | ||
| ``` | ||
| ```go | ||
| ids, train, test, err := load(datasetPath) |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| } | ||
| ``` | ||
| ```go | ||
| for i := range ids [:insertCount] { |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| } | ||
| _, err := client.Insert(ctx, &payload.Insert_Request{ | ||
| Vector: &payload.Object_Vector{ | ||
| Id: ids[i], |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| glg.Fatal(err) | ||
| } | ||
|
|
||
| b, _ := json.MarshalIndent(res.GetResults(), "", " ") |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: B
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| helm install vald vald/vald --values <YOUR VALUES YAML FILE PATH> | ||
| ``` | ||
| ```bash | ||
| helm install vald vald/vald --values <YOUR VALUES YAML FILE PATH> |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
| ```rpc | ||
| service Filter { | ||
| // Represent the RPC to generate the vector. | ||
| rpc GenVector(payload.v1.Object.Blob) returns (payload.v1.Object.Vector) { |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| } | ||
| ``` | ||
| // Represent the RPC to filter the vector. | ||
| rpc FilterVector(payload.v1.Object.Vector) |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| ```rpc | ||
| service Filter { | ||
| // Represent the RPC to filter the distance. | ||
| rpc FilterDistance(payload.v1.Object.Distance) |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| }; | ||
| } | ||
| // Represent the RPC to filter the vector. | ||
| rpc FilterVector(payload.v1.Object.Vector) |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Rpc
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
* Format code with prettier and gofumpt This commit fixes the style issues introduced in 4e10e17 according to the output from prettier and gofumpt. Details: https://deepsource.io/gh/vdaas/vald/transform/3468f768-127e-425d-9457-42cc8d2ef2b2/ * Fix grammar (vdaas#1889) * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * 💚 Separate language tool (vdaas#1890) Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
* Format code with prettier and gofumpt This commit fixes the style issues introduced in 4e10e17 according to the output from prettier and gofumpt. Details: https://deepsource.io/gh/vdaas/vald/transform/3468f768-127e-425d-9457-42cc8d2ef2b2/ * Fix grammar (vdaas#1889) * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * 💚 Separate language tool (vdaas#1890) Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
No description provided.